[web] Add styling in CSS reset to remove Edge password reveal icon#38011
[web] Add styling in CSS reset to remove Edge password reveal icon#38011auto-submit[bot] merged 10 commits intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Gold has detected about 72 new digest(s) on patchset 4. |
nbayati
left a comment
nbayati
left a comment
There was a problem hiding this comment.
Just a nit. Otherwise, LGTM.
|
Gold has detected about 38 new digest(s) on patchset 10. |
* 53d66aa [web] Add styling in CSS reset to remove Edge password reveal icon (flutter/engine#38011) * 0efb0ef [ImpellerC] Print the working directory that was tried when failing to open (flutter/engine#38079)
…6552) * 53d66aa [web] Add styling in CSS reset to remove Edge password reveal icon (flutter/engine#38011) * 0efb0ef [ImpellerC] Print the working directory that was tried when failing to open (flutter/engine#38079)
…6552) * 53d66aa [web] Add styling in CSS reset to remove Edge password reveal icon (flutter/engine#38011) * 0efb0ef [ImpellerC] Print the working directory that was tried when failing to open (flutter/engine#38079)
…6552) * 53d66aa [web] Add styling in CSS reset to remove Edge password reveal icon (flutter/engine#38011) * 0efb0ef [ImpellerC] Print the working directory that was tried when failing to open (flutter/engine#38079)
|
Apparently the issue is not resolved with the following versions of Flutter and Microsoft Edge:
|
As per the release notes, the fix for this lands in Flutter v3.10.0. |
6 participants
Microsoft Edge includes a password reveal icon pseudoelement inside text inputs by default. To allow users to add custom icons to their password inputs and to keep behavior consistent with Chrome and Firefox, we should remove the pseudoelement in password inputs for Edge browsers.
Fixes flutter/flutter#83695
Note for tests:
getComputedStyle()doesn't seem to work with this pseudoelement::-ms-revealin newer versions of Edge, so there doesn't appear to be a way to add a unit test to determine that this style was applied.Pre-launch Checklist
///).