This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[CP] [Windows] Fix headless mode crash#38233
Merged
itsjustkevin merged 1 commit intoflutter:flutter-3.7-candidate.1from Dec 16, 2022
Merged
[CP] [Windows] Fix headless mode crash#38233itsjustkevin merged 1 commit intoflutter:flutter-3.7-candidate.1from
itsjustkevin merged 1 commit intoflutter:flutter-3.7-candidate.1from
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
yaakovschectman
approved these changes
Dec 13, 2022
Contributor
yaakovschectman
left a comment
yaakovschectman
left a comment
There was a problem hiding this comment.
LGTM, though probably going to want a second opinion if this is for a release candidate branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick commit 2148fc0 to
3.7-candidate.1.Original issue: flutter/flutter#116753
Cherry pick issue: flutter/flutter#116932