This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use FML_DCHECK in place of assert in codec utils#38365
Merged
cbracken merged 1 commit intoflutter:mainfrom Dec 17, 2022
cbracken:fix-filename
Merged
Use FML_DCHECK in place of assert in codec utils#38365cbracken merged 1 commit intoflutter:mainfrom cbracken:fix-filename
cbracken merged 1 commit intoflutter:mainfrom
cbracken:fix-filename
Conversation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though the file is pure C code, it's useful to use a C++ or Objective-C++ filename in order to use FML (assertions) in the implementation.
Three implementation changes:
assert()was changed toFML_DCHECKfor consistency with the rest of the embedder.No test changes since there are no semantic changes.
Existing tests are in:
https://github.com/flutter/engine/blob/main/shell/platform/darwin/common/framework/Source/flutter_standard_codec_unittest.mm
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.