This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller Scene] Fix crasher for nodes with no meshes#38374
Merged
bdero merged 1 commit intoflutter:mainfrom Dec 17, 2022
Merged
[Impeller Scene] Fix crasher for nodes with no meshes#38374bdero merged 1 commit intoflutter:mainfrom
bdero merged 1 commit intoflutter:mainfrom
Conversation
zanderso
approved these changes
Dec 17, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 17, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 17, 2022
* 1ae4c7c [Impeller Scene] Fix crasher for nodes with no meshes (flutter/engine#38374) * 7e29698 [Impeller] Move GetSecondsElapsed to Playground (flutter/engine#38375)
loic-sharma
pushed a commit
to loic-sharma/flutter-engine
that referenced
this pull request
Jan 3, 2023
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…7270) * 1ae4c7c [Impeller Scene] Fix crasher for nodes with no meshes (flutter/engine#38374) * 7e29698 [Impeller] Move GetSecondsElapsed to Playground (flutter/engine#38375)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The included test crashes without the fix.
Screen.Recording.2022-12-16.at.10.12.58.PM.mov
I also put some test camera code inline, gonna move it into a reusable utility when we need it again in a playground.