[embedder] Be backwards compatible when getting vkGetInstanceProcAddr#39081
[embedder] Be backwards compatible when getting vkGetInstanceProcAddr#39081nanokatze wants to merge 3 commits intoflutter:mainfrom nanokatze:vk_embedder2
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
nanokatze
changed the title
|
@nanokatze Did you want to land this? |
|
I don't have any preference for either landing this or not. I opened this MR to address a concern brought up by @chinmaygarde in #39051 (comment). My personal opinion on this is that if change introduced by #39051 wasn't actually breaking anyone out there in practice, this PR should not be merged, as I don't see any point in adding compat cruft for bugs that nobody actually came to depend on. |
Co-authored-by: Ian Hickson <[email protected]>
nanokatze
changed the title
|
Closing as this isn't a breaking change. Its possible this is confusing for implementers and we should document it at the very least. |
3 participants
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.