This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Fix grammatical issues in faq.md.#39582
Merged
chinmaygarde merged 2 commits intoflutter:mainfrom Feb 13, 2023
Merged
[Impeller] Fix grammatical issues in faq.md.#39582chinmaygarde merged 2 commits intoflutter:mainfrom
chinmaygarde merged 2 commits intoflutter:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
loic-sharma
reviewed
Feb 13, 2023
loic-sharma
approved these changes
Feb 13, 2023
Member
loic-sharma
left a comment
loic-sharma
left a comment
There was a problem hiding this comment.
Thanks! We should be able to merge this in once you've signed the CLA.
Contributor
Author
|
@loic-sharma thanks, I signed the CLA just now |
Co-authored-by: Loïc Sharma <[email protected]>
chinmaygarde
changed the title
chinmaygarde
approved these changes
Feb 13, 2023
chinmaygarde
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine, pr: 39582, due to - The status or check suite Mac Unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
chinmaygarde
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 13, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 13, 2023
* 7f0aac5 [Impeller] Fix grammatical issues in faq.md. (flutter/engine#39582) * 31a4648 Roll Skia from 9cc86b2a4f27 to f27efe15433d (17 revisions) (flutter/engine#39593)
0xZOne
pushed a commit
to 0xZOne/engine
that referenced
this pull request
Feb 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two grammatical issue in
faq.mdthat bothered me enough to create this PR.