Integrate ios_engine debug, profile and release.#39724
Integrate ios_engine debug, profile and release.#39724auto-submit[bot] merged 2 commits intoflutter:mainfrom godofredoc:single_ios
Conversation
This provides greater reusability of subbuilds saving an approximate of 6 bots per run.
godofredoc
left a comment
godofredoc
left a comment
There was a problem hiding this comment.
Total execution time didn't change too much. ~15min
ci/builders/mac_ios_engine.json
Outdated
| "language": "python3" | ||
| }, | ||
| { | ||
| "name": "Profile-FlutterMacOS.framework", |
There was a problem hiding this comment.
I think I asked this in another PR, but why is building the iOS artifacts called FlutterMacOS.framework? FlutterMacOS.framework is the macOS embedder artifact...
There was a problem hiding this comment.
That was probably an attempt to use a better name than artifacts, which name should we use here? this is just what is shown in the step name.
There was a problem hiding this comment.
Profile-Flutter.xcframework or Profile-ios-Flutter.xcframework would be more accurate.
ci/builders/mac_ios_engine.json
Outdated
| "language": "python3" | ||
| }, | ||
| { | ||
| "name": "Profile-FlutterMacOS.framework", |
There was a problem hiding this comment.
Profile-Flutter.xcframework or Profile-ios-Flutter.xcframework would be more accurate.
My understanding is that the builds for each runtime mode will run in parallel in a separate drone. If that is true, then this lgtm. |
That is correct, everything runs as sub-builds. |
godofredoc
added
the
autosubmit
* 1d7f0c6 Integrate ios_engine debug, profile and release. (flutter/engine#39724) * a37e27b [web] Don't include end-of-line characters in line boundary (flutter/engine#39693)
3 participants
This provides greater reusability of subbuilds saving an approximate of 6 bots per run.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.