This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Mark move-only classes as such#39738
Merged
cbracken merged 1 commit intoflutter:mainfrom Feb 21, 2023
cbracken:windows-fml-moveonly
Merged
[Windows] Mark move-only classes as such#39738cbracken merged 1 commit intoflutter:mainfrom cbracken:windows-fml-moveonly
cbracken merged 1 commit intoflutter:mainfrom
cbracken:windows-fml-moveonly
Conversation
Applies the FML_DISALLOW_COPY_AND_ASSIGN to non-POD types in the Windows embedder. No new tests since no semantic change. Only has the compile-time effect of preventing copying of classes intended to be move-only.
yaakovschectman
approved these changes
Feb 21, 2023
Contributor
yaakovschectman
left a comment
yaakovschectman
left a comment
There was a problem hiding this comment.
LGTM, mod one question
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 21, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 21, 2023
* 5b00a95 Roll Skia from 2f05923f825e to a16472080754 (18 revisions) (flutter/engine#39772) * c3d9c30 [Windows] Mark move-only classes as such (flutter/engine#39738)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the FML_DISALLOW_COPY_AND_ASSIGN to non-POD types in the Windows embedder.
Also #includes fml/macros.h in a few places we were already using the macro, but missed int #include.
No new tests since no semantic change. Only has the compile-time effect of preventing copying of classes intended to be move-only.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.