Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Prepare for NULLABLE_ARGUMENT_TO_NON_NULL_TYPE#39816

Closed
asashour wants to merge 1 commit intoflutter:mainfrom
asashour:121318_nullable_diagnostic
Closed

Prepare for NULLABLE_ARGUMENT_TO_NON_NULL_TYPE#39816
asashour wants to merge 1 commit intoflutter:mainfrom
asashour:121318_nullable_diagnostic

Conversation

@asashour
Copy link
Contributor

@asashour asashour commented Feb 23, 2023

flutter/flutter#121318

This PR modifies the code in order not to trigger the incoming diagnostic.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Feb 23, 2023
@asashour asashour mentioned this pull request Feb 23, 2023
Open
3 tasks
@christopherfujino
Copy link
Contributor

christopherfujino commented Apr 25, 2023

@asashour looks like you have a merge conflict on this one

@Hixie
Copy link
Contributor

Hixie commented Jun 20, 2023

I'm going to close this one since it seems we have abandoned this transition, but I think the correct way of fixing this is not to add a ! but to make the Complete take a ByteData?, for what it's worth.

@Hixie Hixie closed this Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mdebbar mdebbar mdebbar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-web Code specifically for the web engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@asashour @christopherfujino @Hixie @mdebbar