This repository was archived by the owner on Feb 25, 2025. It is now read-only.
delete DL ops no longer needed after removing SkCanvasRecorder#39863
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom Feb 25, 2023
Merged
delete DL ops no longer needed after removing SkCanvasRecorder#39863auto-submit[bot] merged 1 commit intoflutter:mainfrom
auto-submit[bot] merged 1 commit intoflutter:mainfrom
Conversation
flar
force-pushed
the
remove-SkCanvas-exclusive-DL-ops
branch
from
6a8e416 to
7076b8b
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 25, 2023
dnfield
pushed a commit
to dnfield/engine
that referenced
this pull request
Feb 27, 2023
…er#39863) delete DL ops no longer needed after removing SkCanvasRecorder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is pretty simple "obsolete code" fallout from removing DisplayListCanvasRecorder. Some of the DisplayList ops were only ever captured on a theoretical basis from an SkCanvas object. Since we no longer capture from SkCanvas, we can delete the methods and objects that aren't directly recordable from our own DisplayList APIs. These include:
The 1000 lines are almost all straight deletions, and maybe some comment updates to no longer discuss objects we never see. Lots of Impeller::UNIMPLEMENTED removals...