[Impeller] dont create mipmap when mipcount == 1#39950
[Impeller] dont create mipmap when mipcount == 1#39950auto-submit[bot] merged 1 commit intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jonahwilliams
added
the
autosubmit
|
I was going to suggest that the blit pass do nothing in case the mip count is not greater than 1. What that would be good to add anyway, we should also encourage folks to not create the pass in the first place. |
jonahwilliams
added
autosubmit
2 participants
I can verify this with an integration test, but is that fact that we created mipmaps observable through the impeller API so I can write a simpler unittest?
Fixes flutter/flutter#121015