Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove special handling of gtk debug artifact.#40040

Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom
godofredoc:remove_special_gtk
Mar 3, 2023
Merged

Remove special handling of gtk debug artifact.#40040
auto-submit[bot] merged 2 commits intoflutter:mainfrom
godofredoc:remove_special_gtk

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Mar 3, 2023

The debug gtk artifact path was inconsistent with the release and profile paths. This PR is making the path calculation consistent.

flutter/flutter#120658 updated the tool to use a consistent path for debug.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Remove special handling of gtk debug artifact.
a286494 
The debug gtk artifact path was inconsistent with the release and profile paths.
This PR is making the path calculation consistent.

flutter/flutter#120658 updated the tool to use a
consistent path for debug.
@godofredoc godofredoc requested review from cbracken and zanderso March 3, 2023 04:38
cbracken
cbracken approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 3, 2023
@auto-submit auto-submit bot merged commit 9809d97 into flutter:main Mar 3, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2023
@engine-flutter-autoroll
9809d97 Remove special handling of gtk debug artifact. (flutter/engin…
a41ae46 
…e#40040)
@godofredoc godofredoc deleted the remove_special_gtk branch March 8, 2023 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zanderso zanderso Awaiting requested review from zanderso

1 more reviewer

@cbracken cbracken cbracken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-linux

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@godofredoc @cbracken