Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove bringup from web engine build.#40117

Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom
godofredoc:remove_bringup
Mar 7, 2023
Merged

Remove bringup from web engine build.#40117
auto-submit[bot] merged 1 commit intoflutter:mainfrom
godofredoc:remove_bringup

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Mar 7, 2023

The build has been passing consistently and removing bringup will allow to validate changes to the build in presubmit.

Bug: flutter/flutter#119036

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Remove bringup from web engine build.
ceb801e 
The build has been passing consistently and removing bringup will allow
to validate changes to the build in presubmit.

Bug: flutter/flutter#119036
eyebrowsoffire
eyebrowsoffire approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godofredoc godofredoc added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Mar 7, 2023
@auto-submit auto-submit bot merged commit 000a8c9 into flutter:main Mar 7, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 7, 2023
@engine-flutter-autoroll
000a8c9 Remove bringup from web engine build. (flutter/engine#40117)
d54b1b7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 7, 2023
@engine-flutter-autoroll
000a8c9 Remove bringup from web engine build. (flutter/engine#40117)
425dc37
@godofredoc godofredoc deleted the remove_bringup branch March 8, 2023 16:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@eyebrowsoffire eyebrowsoffire eyebrowsoffire approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@godofredoc @eyebrowsoffire