This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add new Dart package dependency on dart-lang/tools#40118
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom Mar 7, 2023
Merged
Add new Dart package dependency on dart-lang/tools#40118auto-submit[bot] merged 1 commit intoflutter:mainfrom
auto-submit[bot] merged 1 commit intoflutter:mainfrom
Conversation
The new Dart SDK dependency on the dart-lang/tools repo needs to be manually added to engine DEPS. The new package includes a unified_analytics package used by the analysis server. The builds of Flutter engine with a prebuilt Dart SDK do not require it, but any builds of Flutter engine that build the Dart SDK do need this package. The package was added to Dart DEPS in https://dart-review.googlesource.com/c/sdk/+/283921 The package started being used in the SDK build process in commit https://dart-review.googlesource.com/c/sdk/+/286600
devoncarew
approved these changes
Mar 7, 2023
zanderso
reviewed
Mar 7, 2023
| Var('dart_git') + '/test_reflective_loader.git@c4c2d5c3f94a96f3fc79e9e28944fba391bc544c', | ||
|
|
||
| 'src/third_party/dart/third_party/pkg/tools': | ||
| Var('dart_git') + '/tools.git@28b7be83589d0d7a6d44cbe6166b6673f08018fb', |
Member
There was a problem hiding this comment.
Does this need to be rolled forward to match the version in the Dart SDK DEPS file when the Dart SDK rolls into the engine?
Member
There was a problem hiding this comment.
The https://github.com/flutter/buildroot/blob/master/tools/dart/create_updated_flutter_deps.py script recognizes entries in this format and will copy updates from Dart's DEPS
Contributor
Author
There was a problem hiding this comment.
Yes, adding a new dependency is a one-time operation, after that, it updates when the revision in Dart DEPS changes, just like the other deps.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 7, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new Dart SDK dependency on the dart-lang/tools repo needs to be manually added to engine DEPS.
The new package includes a unified_analytics package used by the analysis server. The builds of Flutter engine with a prebuilt Dart SDK do not require it, but any builds of Flutter engine that build the Dart SDK do need this package.
The package was added to Dart DEPS in
https://dart-review.googlesource.com/c/sdk/+/283921
The package started being used in the SDK build process in commit https://dart-review.googlesource.com/c/sdk/+/286600