Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix some includes missing "flutter/" prefix.#40122

Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom
gspencergoog:fix_includes
Mar 7, 2023
Merged

Fix some includes missing "flutter/" prefix.#40122
auto-submit[bot] merged 1 commit intoflutter:mainfrom
gspencergoog:fix_includes

Conversation

@gspencergoog
Copy link
Contributor

This fixes a couple of files where the include path started with "shell/" instead of "flutter/shell/". This is for consistency with other includes.

@flutter-dashboard flutter-dashboard bot added the embedder Related to the embedder API label Mar 7, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@CaseyHillers
Copy link
Contributor

test-exempt: Fix imports to align with Google Testing's BUILD system

Copy link
Contributor

@CaseyHillers CaseyHillers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the cleanup

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 7, 2023
@auto-submit auto-submit bot merged commit 825f316 into flutter:main Mar 7, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App embedder Related to the embedder API needs tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants