This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove single window assumption from testing/dart#40160
Merged
goderbauer merged 2 commits intoflutter:mainfrom Mar 9, 2023
Merged
Remove single window assumption from testing/dart#40160goderbauer merged 2 commits intoflutter:mainfrom
goderbauer merged 2 commits intoflutter:mainfrom
Conversation
loic-sharma
reviewed
Mar 9, 2023
| final Scene scene = builder.build(); | ||
|
|
||
| window.render(scene); | ||
| PlatformDispatcher.instance.implicitView!.render(scene); |
Member
There was a problem hiding this comment.
The comments on line 40 and lines 42-43 look like test code that was never removed. Consider deleting it if you feel like it :)
loic-sharma
approved these changes
Mar 9, 2023
goderbauer
added
the
autosubmit
33 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#116929.