This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Desktop] Use references for semantics update#40167
Merged
auto-submit[bot] merged 4 commits intoflutter:mainfrom Mar 9, 2023
Merged
[Desktop] Use references for semantics update#40167auto-submit[bot] merged 4 commits intoflutter:mainfrom
auto-submit[bot] merged 4 commits intoflutter:mainfrom
Conversation
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
AccessibilityBridge::AddFlutterSemanticsNodeUpdateandAccessibilityBridge::AddFlutterSemanticsCustomActionUpdateto accept references instead of pointers as null isn't an acceptable input and these aren't out parameters.This code is shared by both the macOS and Windows embedders but not the Linux embedder.
Part of: flutter/flutter#121176
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.