Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Use CK's malloced array correctly#40181

Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom
mdebbar:ck_typed_array
Mar 9, 2023
Merged

[web] Use CK's malloced array correctly#40181
auto-submit[bot] merged 2 commits intoflutter:mainfrom
mdebbar:ck_typed_array

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Mar 9, 2023

Pass the malloced array to CanvasKit instead of passing the underlying typed array.

@mdebbar mdebbar requested a review from eyebrowsoffire March 9, 2023 18:33
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Mar 9, 2023
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Small thing that you can ignore if you don't care.

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 9, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 9, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 9, 2023

auto label is removed for flutter/engine, pr: 40181, due to - The status or check suite Linux Web Framework tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 9, 2023
@auto-submit auto-submit bot merged commit 832298b into flutter:main Mar 9, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 9, 2023
@mdebbar mdebbar deleted the ck_typed_array branch June 22, 2023 21:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants