This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Switched floats to ints in gradient shaders for better performance#40189
Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom Mar 9, 2023
Merged
Switched floats to ints in gradient shaders for better performance#40189auto-submit[bot] merged 2 commits intoflutter:mainfrom
auto-submit[bot] merged 2 commits intoflutter:mainfrom
Conversation
gaaclarke
force-pushed
the
test-explicit-conversion
branch
from
45801de to
3f8b90b
Compare
gaaclarke
changed the title
jonahwilliams
approved these changes
Mar 9, 2023
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM!
@zanderso we should configure malioc to run on the vulkan spv modules too
gaaclarke
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While researching flutter/flutter#122324 I saw that this was an easy performance gain, might as well land it while we wait to remove implicit conversions.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.