This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Fix crash if clipboard is set to null#40238
Merged
loic-sharma merged 2 commits intoflutter:mainfrom Mar 16, 2023
Merged
[Windows] Fix crash if clipboard is set to null#40238loic-sharma merged 2 commits intoflutter:mainfrom
loic-sharma merged 2 commits intoflutter:mainfrom
Conversation
loic-sharma
force-pushed
the
windows_clipboard_crash
branch
from
ed19733 to
efc04c2
Compare
loic-sharma
changed the title
yaakovschectman
approved these changes
Mar 13, 2023
cbracken
approved these changes
Mar 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the framework allows setting the clipboard to
null. This was an unintentional mistake from thenullsafety migration and platforms handle this case incorrectly. We will update the framework to disallow setting the clipboard's data tonull: flutter/flutter#122446In the meantime, this change makes the Windows embedder resilient to unexpected clipboard messages. If your clipboard data's text is unexpected, you will now get an error instead of crashing your app.
Part of flutter/flutter#121976