[impeller] disable opacity peephole due to stencil issues#40497
[impeller] disable opacity peephole due to stencil issues#40497auto-submit[bot] merged 2 commits intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jonahwilliams
force-pushed
the
fix_stencil
branch
from
32fb565 to
fd54a25
Compare
bdero
left a comment
bdero
left a comment
There was a problem hiding this comment.
LGTM.
Stencil coverage is one of the most annoying things to debug at the moment and I've been working on some tooling to help with this. Right now I usually end up doing a combination of print debugging and conditional breaks. :/
jonahwilliams
added
the
autosubmit
…utter#40497)" This reverts commit 24e0dd7.
2 participants
This causes rendering issues on wonderous that I missed. I think we're screwing up the stencil depth checks when collapsing