This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Refactor Cubic/Quad tests to make sure all threads reach barrier()#40506
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom Mar 21, 2023
Merged
[Impeller] Refactor Cubic/Quad tests to make sure all threads reach barrier()#40506auto-submit[bot] merged 1 commit intoflutter:mainfrom
auto-submit[bot] merged 1 commit intoflutter:mainfrom
Conversation
Contributor
Author
|
Probably should've added in the description - if some thread fails to reach |
dnfield
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 22, 2023
Member
|
Testing is something that we should discuss after the next branch cut and before the GPU compute code goes live. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also does some refactoring to move code under test to a shared file for future use in the more generalized path polyline generator.
This is another part of addressing flutter/flutter#122828.
The last piece left is to split invocations up into chunks that fit into the
threadExecutionWidth.I don't have a test with this change, but it will be tested when we re-enable the tests from the linked issue on Intel machines. Ideally we'd have some kind of linting or fuzzing for this, but there's no good existing solution for that right now.