Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Use target platform name when generating artifacts.#40519

Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom
godofredoc:use_target_name
Mar 23, 2023
Merged

Use target platform name when generating artifacts.#40519
auto-submit[bot] merged 2 commits intoflutter:mainfrom
godofredoc:use_target_name

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Mar 22, 2023

This is to ensure artifacts are generated in the correct location for mac arm64 cpus.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Use target platform name when generating artifacts.
3d4e6d8 
This is to ensure artifacts are generated in the correct location for
mac arm64 cpus.
@godofredoc godofredoc requested a review from zanderso March 22, 2023 05:22
@godofredoc godofredoc requested a review from dnfield March 23, 2023 19:11
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 23, 2023
@auto-submit auto-submit bot merged commit 2520943 into flutter:main Mar 23, 2023
@godofredoc godofredoc deleted the use_target_name branch March 23, 2023 20:59
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 23, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
2520943 Use target platform name when generating artifacts. (flutter/…
d0c6e01 
…engine#40519)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dnfield dnfield Awaiting requested review from dnfield

1 more reviewer

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@godofredoc @zanderso