Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Update ICU dependency to updated build#40676

Merged
yaakovschectman merged 4 commits intoflutter:mainfrom
yaakovschectman:icudtl_commit
Mar 28, 2023
Merged

Update ICU dependency to updated build#40676
yaakovschectman merged 4 commits intoflutter:mainfrom
yaakovschectman:icudtl_commit

Conversation

@yaakovschectman
Copy link
Contributor

@yaakovschectman yaakovschectman commented Mar 27, 2023

Updates the commit of ICU pulled from Chromium as a dependency. The new update includes a separate flutter_desktop build that includes collation data we can use for a11y purposes. This PR does not yet change the icudlt file used by desktop builds, it only updates the commit of ICU used. I intend to the above in a follow-up commit once we can be sure this can roll out.

Part of flutter/flutter#117013

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@yaakovschectman yaakovschectman added accessibility affects: desktop dependencies Pull requests that update a dependency file labels Mar 27, 2023
@yaakovschectman yaakovschectman self-assigned this Mar 27, 2023
@loic-sharma
Copy link
Member

loic-sharma commented Mar 27, 2023

@yaakovschectman Looks like you'll need to update licenses for checks to pass.

cbracken
cbracken approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. The patch command in the output likely won’t work as-is on Windows, but you can hand-edit the file to fix, and I suspect git apply would work.

If so, feel free to send a patch to emit an updated command that works on all platforms.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 28, 2023

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #40676 at sha e6fc224

@yaakovschectman yaakovschectman merged commit eb64764 into flutter:main Mar 28, 2023
@yaakovschectman yaakovschectman deleted the icudtl_commit branch March 28, 2023 20:02
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
eb64764 Update ICU dependency to updated build (flutter/engine#40676)
eb35e6e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dkwingsmt dkwingsmt Awaiting requested review from dkwingsmt

2 more reviewers

@cbracken cbracken cbracken approved these changes

@loic-sharma loic-sharma loic-sharma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yaakovschectman yaakovschectman

Labels

accessibility affects: desktop dependencies Pull requests that update a dependency file will affect goldens

Projects

Flutter Desktop
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yaakovschectman @loic-sharma @cbracken