This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use new SkImages namespace instead of legacy SkImage static functions#40761
Merged
auto-submit[bot] merged 5 commits intoflutter:mainfrom Mar 30, 2023
Merged
Use new SkImages namespace instead of legacy SkImage static functions#40761auto-submit[bot] merged 5 commits intoflutter:mainfrom
auto-submit[bot] merged 5 commits intoflutter:mainfrom
Conversation
chinmaygarde
approved these changes
Mar 30, 2023
jason-simmons
approved these changes
Mar 30, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In https://skia-review.googlesource.com/c/skia/+/661059, Skia added a new SkImages namespace and deprecated using static functions on SkImage as part of an effort to separate the SkImage class and the GPU backends.
This PR replaces all old calls with the new calls, which should be functionally the same. It makes sure
SkImage.handSkImageGanesh.hare #included where appropriate.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.