This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] LRU cache for text segmentation#40782
Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom Mar 30, 2023
Merged
Conversation
flutter-dashboard
bot
added
the
platform-web
kevmoo
reviewed
Mar 30, 2023
| import '../util.dart'; | ||
| import 'canvaskit_api.dart'; | ||
|
|
||
| typedef SegmentationResult = ({ |
Contributor
|
@mdebbar – do we have numbers for this? Memory increase? Speed improvements? |
Contributor
Author
|
I'm not sure how to run all the combinations that the team has been tracking. @yjbanov wanna give this a shot? One thing I know is this PR doesn't affect text layout benchmarks because this PR improves paragraph building, but has no effect on paragraph layout. The PR should still affect other app-like benchmarks (e.g. color grid). Also, this PR will only affect the Chromium build of CanvasKit. |
mdebbar
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few changes in this PR:
ParagraphBuilder.RequiresClientICU()only once and cache the result.browserSupportsCanvaskitChromium.