[Impeller] Go back to using MSL compiler backend for Vulkan#40786
[Impeller] Go back to using MSL compiler backend for Vulkan#40786auto-submit[bot] merged 2 commits intomainfrom
Conversation
This somehow seems to have regressed OpenGLES on Android. We can figure out what's going on later.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| sl_options.force_zero_initialized_variables = true; | ||
| gl_compiler->set_common_options(sl_options); | ||
| return CompilerBackend(gl_compiler); | ||
| // TODO(dnfield): It seems like what we'd want is a CompilerGLSL with |
There was a problem hiding this comment.
Should this go in a GitHub issue?
There was a problem hiding this comment.
Filing one and will add it here.
dnfield
added
the
autosubmit
3 participants
This somehow seems to have regressed OpenGLES on Android. We can figure out what's going on later.