[Impeller] Some fixes to shader pipeline validation#40925
[Impeller] Some fixes to shader pipeline validation#40925auto-submit[bot] merged 1 commit intoflutter:mainfrom
Conversation
jason-simmons
commented
Apr 4, 2023
jason-simmons
commented
- Fix a typo in GLES fragment shader error checking
- Assert if a pipeline future returns null
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
|
||
| auto variant_future = prototype->second->WaitAndGet()->CreateVariant( | ||
| auto pipeline = prototype->second->WaitAndGet(); | ||
| FML_CHECK(pipeline); |
There was a problem hiding this comment.
We should return nullptr here like we do above. I think its possible to get null if we run into device loss.
* Fix a typo in GLES fragment shader error checking * Assert if a pipeline future returns null
jason-simmons
force-pushed
the
iplr_frag_status_check
branch
from
3a25052 to
bc7393b
Compare
jason-simmons
added
the
autosubmit
[Impeller] Some fixes to shader pipeline validation
2 participants
