[Impeller] Keep a reference to BlitPassGLES in the EncodeCommands lambda to prevent use-after-free#41100
Conversation
…bda to prevent use-after-free Without this the BlitPassGLES and its command list can be destructed before the reactor executes the lambda.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
I think we want the same applies to renderpassgles too right? |
|
But we might get a performance improvement by doing something like this in |
jason-simmons
added
the
autosubmit
…ands lambda to prevent use-after-free (flutter/engine#41100)
…bda to prevent use-after-free (flutter#41100) [Impeller] Keep a reference to BlitPassGLES in the EncodeCommands lambda to prevent use-after-free
3 participants
Without this the BlitPassGLES and its command list can be destructed before the reactor executes the lambda.