Add builders for arm64 on macOS unopt#41141
Conversation
dnfield
changed the title
| "type": "gcs", | ||
| "include_paths": [ | ||
| ], | ||
| "name": "host_debug_unopt_arm64" |
There was a problem hiding this comment.
Is the only purpose of this build to validate it builds correctly?
There was a problem hiding this comment.
For now, until we can run tests.
There was a problem hiding this comment.
I should have said:
We're not ready to run host unit tests on CI for reasons in flutter/flutter#103386. It seems close.
This is running tests on iOS simulator though.
| "os=Mac-12", | ||
| "cpu=arm64" | ||
| ], | ||
| "gclient_custom_vars": { |
There was a problem hiding this comment.
This was copy-pasted from the other ones.
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
cc @keyonghan this will add more arm builders that potentially could be xcode-cache corrupted if we try to update just the arm bots to test out your named cache work. However we can turn these off temporarily if that's a problem, if needed.
LGTM once @godofredoc is happy.
|
Adding my +2 with nits because I'll be ooo the rest of the day. |
dnfield
added
the
autosubmit
Add builders for arm64 on macOS unopt
3 participants
Fixes flutter/flutter#122534
Adds a descritiption for building the host_debug_unopt_arm64 and ios_sim_unopt_arm64 to the mac arm64 bots.
Does not run host tests yet, but will be easy to do that after flutter/flutter#103386 is resolved.
@cbracken fyi