[Impeller] Print a log on all non-recoverable failure paths in EntityPass#41178
[Impeller] Print a log on all non-recoverable failure paths in EntityPass#41178bdero merged 1 commit intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
I think the unrelated golden issue is on the base branch and fixed at HEAD, so ignoring. |
…Pass (flutter#41178) This eliminates a lot of surface area when debugging non-recoverable frame failures such as flutter#41129. Every failure case should be covered with at least one log, but without recursive log spam.
2 participants
This eliminates a lot of surface area when debugging non-recoverable frame failures such as #41129. Every failure case should be covered with at least one log, but without recursive log spam.