This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Move scenario app to use iPhone Se 3rd gen iOS 16.2, un-skip test TwoPlatformViewsWithOtherBackDropFilterTests#41532
Merged
auto-submit[bot] merged 4 commits intoflutter:mainfrom May 1, 2023
Conversation
update the test simulator update proj file
cyanglaz
force-pushed
the
scenario_to_se
branch
from
27a9b37 to
3c5b966
Compare
cyanglaz
changed the title
TwoPlatformViewsWithOtherBackDropFilterTests
Contributor
Author
|
Well, my local arm failed the |
cyanglaz
commented
Apr 28, 2023
Contributor
Author
There was a problem hiding this comment.
I think git is confused and compared the wrong file. You can check the full file names by hovering the mouse to file name above. Same as the one below.
jmagman
reviewed
May 1, 2023
Member
There was a problem hiding this comment.
You can land this now, rebase #41640 onto it, and either update ios-16-0_14a5294e to ios-16-2_14c18 or remove totally and update the images again.
https://github.com/flutter/engine/pull/41640/files#r1181847615
cyanglaz
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2023
…test `TwoPlatformViewsWithOtherBackDropFilterTests` (flutter/engine#41532)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2023
…test `TwoPlatformViewsWithOtherBackDropFilterTests` (flutter/engine#41532)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2023
…test `TwoPlatformViewsWithOtherBackDropFilterTests` (flutter/engine#41532)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 2, 2023
flutter/engine@3fa6084...7d87410 2023-05-01 [email protected] Update xcode to 14e222b (flutter/engine#41640) 2023-05-01 [email protected] Run flutter license script with dart `--intrepret_irregexp` runtime option (flutter/engine#41646) 2023-05-01 [email protected] Roll Skia from 82d1ef7a833e to 38e56b6da8f9 (8 revisions) (flutter/engine#41645) 2023-05-01 [email protected] Move scenario app to use iPhone Se 3rd gen iOS 16.2, un-skip test `TwoPlatformViewsWithOtherBackDropFilterTests` (flutter/engine#41532) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iPhone 8 is old and not installed by default with the latest XCodes. Move the scenario test to a newer iPhone that has a home button. (Unfortunately, iPhones without home button have the bottom navigation bar that animates, resulting inconsistency during screenshots)
Fixes flutter/flutter#125167
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.