This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Migrate desktop artifacts to engine v2.#41599
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom Apr 28, 2023
godofredoc:migrate_desktop
Merged
Migrate desktop artifacts to engine v2.#41599auto-submit[bot] merged 1 commit intoflutter:mainfrom godofredoc:migrate_desktop
auto-submit[bot] merged 1 commit intoflutter:mainfrom
godofredoc:migrate_desktop
Conversation
The desktop artifacts are generated using gn+ninja in both the legacy and engine v2 builds. This change is making the engine v2 the primary build. This change needs to land before https://flutter-review.googlesource.com/c/recipes/+/43340 which is removing the desktop artifacts from the legacy builder to avoid trying to upload the same artifacts multiple times. There will be some propagation time, 1 or 2 commits where the artifacts will try to be uploaded twice making the legacy Linux Host Engine build fail and recover automatically with the auto-retry.
zanderso
approved these changes
Apr 28, 2023
godofredoc
added
the
autosubmit
cbracken
reviewed
Apr 29, 2023
Member
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
Awesome - thanks for making this happen @godofredoc!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 29, 2023
flutter/engine@3835d97...89a8aff 2023-04-28 [email protected] Roll Skia from 9867fa253064 to 49412cbee072 (13 revisions) (flutter/engine#41597) 2023-04-28 [email protected] Migrate desktop artifacts to engine v2. (flutter/engine#41599) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop artifacts are generated using gn+ninja in both the legacy and engine v2 builds. This change is making the engine v2 the primary build.
This change needs to land before https://flutter-review.googlesource.com/c/recipes/+/43340 which is removing the desktop artifacts from the legacy builder to avoid trying to upload the same artifacts multiple times.
There will be some propagation time, 1 or 2 commits where the artifacts will try to be uploaded twice making the legacy Linux Host Engine build fail and recover automatically with the auto-retry.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.