Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Update xcode to 14e222b#41640

Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom
cyanglaz:xcode_to_14_3
May 1, 2023
Merged

Update xcode to 14e222b#41640
auto-submit[bot] merged 2 commits intoflutter:mainfrom
cyanglaz:xcode_to_14_3

Conversation

@cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented May 1, 2023

Engine part of. flutter/flutter#125814

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman mentioned this pull request May 1, 2023
Closed
8 tasks
@cyanglaz cyanglaz marked this pull request as ready for review May 1, 2023 19:18
@cyanglaz cyanglaz requested a review from jmagman May 1, 2023 19:18
jmagman
jmagman suggested changes May 1, 2023
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to audit the ci/builders subbuilds:
https://github.com/flutter/engine/blob/58cc54197a5486044a9fdadec707f8d0b66d1d61/ci/builders/mac_unopt.json#LL65C35-L65C40

./ci/builders/mac_android_aot_engine.json:                    "sdk_version": "14c18"
./ci/builders/mac_android_aot_engine.json:                    "sdk_version": "14c18"
./ci/builders/mac_android_aot_engine.json:                    "sdk_version": "14c18"
./ci/builders/mac_android_aot_engine.json:                    "sdk_version": "14c18"
./ci/builders/mac_android_aot_engine.json:                    "sdk_version": "14c18"
./ci/builders/mac_android_aot_engine.json:                    "sdk_version": "14c18"
./ci/builders/README.md:        { "sdk_version": "14c18" }
./ci/builders/mac_unopt.json:                    "sdk_version": "14c18"
./ci/builders/mac_unopt.json:                        "ios-16-2_14c18",
./ci/builders/mac_unopt.json:                    "sdk_version": "14c18"
./ci/builders/mac_unopt.json:                    "sdk_version": "14c18"
./ci/builders/mac_unopt.json:                        "ios-16-2_14c18",
./ci/builders/mac_unopt.json:                    "sdk_version": "14c18"

@cyanglaz cyanglaz requested a review from jmagman May 1, 2023 19:33
@jmagman jmagman mentioned this pull request May 1, 2023
Merged
8 tasks
jmagman
jmagman reviewed May 1, 2023
View reviewed changes
ci/builders/mac_unopt.json Outdated
Comment on lines 65 to 66
"ios-16-3_14e222b",
"ios-16-0_14a5294e"
Copy link
Member

@jmagman jmagman May 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note if you land #41532 this will need to become:

                        "ios-16-3_14e222b",
                        "ios-16-2_14c18",

Copy link
Contributor Author

@cyanglaz cyanglaz May 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to 16.2 for scenario apps, will rebase when #41532 lands.

Copy link
Contributor Author

@cyanglaz cyanglaz May 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebased.

@cyanglaz
Copy link
Contributor Author

cyanglaz commented May 1, 2023 

  flutter_internal/ios/xcode/ios_runtime: no such ref.
[W 2023-05-01 12:37:48] Failed to resolve ref: ios-16-3_14e222b. Error: Error when resolving package path flutter_internal/ios/xcode/ios_runtime with ref ios-16-3_14e222b.: exit status 1
[E 2023-05-01 12:37:48] original error: Failed to resolve runtime ref given runtime version: ios-16-3_14e222b, xcode version: .

goroutine 1:
#0 mac_toolchain/install.go:411 - main.resolveRuntimeRef()
  reason: Failed to resolve runtime ref given runtime version: ios-16-3_14e222b, xcode version: .

#1 mac_toolchain/install.go:437 - main.installRuntime()
  reason: failed to resolve runtime cipd ref. Xcode version: , runtime version: ios-16-3_14e222b

#2 mac_toolchain/main.go:379 - main.(*installRuntimeRun).Run()
#3 github.com/maruel/[email protected]/subcommands.go:395 - subcommands.Run()
#4 mac_toolchain/main.go:628 - main.main()
#5 runtime/proc.go:250 - runtime.main()
#6 runtime/asm_amd64.s:1598 - runtime.goexit()```

@jmagman
Copy link
Member

jmagman commented May 1, 2023

[W 2023-05-01 12:37:48] Failed to resolve ref: ios-16-3_14e222b. Error: Error when resolving package path flutter_internal/ios/xcode/ios_runtime with ref ios-16-3_14e222b.: exit status 1

It's ios-16-4_14e222b
https://chrome-infra-packages.appspot.com/p/flutter_internal/ios/xcode/ios_runtime/+/ios-16-4_14e222b

Xcode 14.3 includes Swift 5.8 and SDKs for iOS 16.4, iPadOS 16.4, tvOS 16.4, watchOS 9.4, and macOS Ventura 13.3

update xcode to 14e222b
ac6a4e9 
update builderse

fix: 16.3 -> 16.4

makes scenario apps runs on iOS 16.2
@cyanglaz cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label May 1, 2023
@auto-submit auto-submit bot merged commit 7d87410 into flutter:main May 1, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2023
@engine-flutter-autoroll
7d87410 Update xcode to 14e222b (flutter/engine#41640)
a479dd1
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 2, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 3fa6084 to 7d87410 (4 revisions) (#125845)
d304545 
flutter/engine@3fa6084...7d87410

2023-05-01 [email protected] Update xcode to 14e222b (flutter/engine#41640)
2023-05-01 [email protected] Run flutter license script with dart `--intrepret_irregexp` runtime option (flutter/engine#41646)
2023-05-01 [email protected] Roll Skia from 82d1ef7a833e to 38e56b6da8f9 (8 revisions) (flutter/engine#41645)
2023-05-01 [email protected] Move scenario app to use iPhone Se 3rd gen iOS 16.2, un-skip test `TwoPlatformViewsWithOtherBackDropFilterTests` (flutter/engine#41532)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jmagman jmagman jmagman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cyanglaz @jmagman