Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

CP: Windows unopt configuration. (#41785)#41841

Merged
godofredoc merged 1 commit intoflutter:flutter-3.11-candidate.0from
godofredoc:beta_cp_2
May 10, 2023
Merged

CP: Windows unopt configuration. (#41785)#41841
godofredoc merged 1 commit intoflutter:flutter-3.11-candidate.0from
godofredoc:beta_cp_2

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented May 9, 2023

CP: 9420c50

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Windows unopt configuration. (#41785)
1e43a05 
This PR also add a standalone folder to the build configurations folder. This is to separate configurations that require orchestrators from the ones the do not require them.

Bug: flutter/flutter#126120

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@godofredoc godofredoc mentioned this pull request May 9, 2023
Closed
XilaiZhang
XilaiZhang approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@XilaiZhang XilaiZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

images (1)

@godofredoc godofredoc merged commit b6c0113 into flutter:flutter-3.11-candidate.0 May 10, 2023
@godofredoc godofredoc deleted the beta_cp_2 branch May 10, 2023 17:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@itsjustkevin itsjustkevin Awaiting requested review from itsjustkevin

@CaseyHillers CaseyHillers Awaiting requested review from CaseyHillers

2 more reviewers

@XilaiZhang XilaiZhang XilaiZhang approved these changes

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@godofredoc @XilaiZhang @fluttergithubbot