This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Move checkerboard unit tests onto DisplayList mechanism#41951
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom May 25, 2023
Merged
Move checkerboard unit tests onto DisplayList mechanism#41951auto-submit[bot] merged 1 commit intoflutter:mainfrom
auto-submit[bot] merged 1 commit intoflutter:mainfrom
Conversation
Contributor
Author
|
The number of changes seems larger than it should for a couple of reasons:
|
chinmaygarde
approved these changes
May 25, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 25, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 25, 2023
flutter/engine@6a4e675...ff04d2f 2023-05-25 [email protected] Move checkerboard unit tests onto DisplayList mechanism (flutter/engine#41951) 2023-05-25 [email protected] [Skwasm] Implement miscellaneous drawing APIs (flutter/engine#42324) 2023-05-25 [email protected] Roll Fuchsia Mac SDK from X4uS4T6_J-VUh9M4A... to AgIKKqtBtb6RJnyI9... (flutter/engine#42326) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from X4uS4T6_J-VU to AgIKKqtBtb6R If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of an ongoing set of efforts to address flutter/flutter#106448
Move the checkerboard layer unit tests onto the DisplayList version of the paint contexts and fix some bugs in the reusability of the DisplayListBuilder that this migration uncovered.