This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS] Clean up unused methods in FlutterRenderer#42196
Merged
dkwingsmt merged 5 commits intoflutter:mainfrom May 21, 2023
Merged
[macOS] Clean up unused methods in FlutterRenderer#42196dkwingsmt merged 5 commits intoflutter:mainfrom
dkwingsmt merged 5 commits intoflutter:mainfrom
Conversation
chinmaygarde
approved these changes
May 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2023
cbracken
reviewed
May 22, 2023
Member
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
Nice. There's a bit of followup cleanup we should land. I'll send a patch.
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
May 22, 2023
flutter/engine@f0f3fe7...e04c147 2023-05-22 [email protected] Roll Fuchsia Linux SDK from NE_eTA29vOHN4goJL... to LrfeC0dLk8ToJVik5... (flutter/engine#42208) 2023-05-22 [email protected] Roll Fuchsia Mac SDK from HPZKiLZlLCR6moOCE... to QAwORJOkyNl4J3x4Y... (flutter/engine#42207) 2023-05-22 [email protected] Roll Skia from 16c60e5bebfc to ef226c5a7930 (1 revision) (flutter/engine#42206) 2023-05-22 [email protected] Roll Skia from 79088c6b7a33 to 16c60e5bebfc (1 revision) (flutter/engine#42205) 2023-05-22 [email protected] Roll Skia from 76303a5498e9 to 79088c6b7a33 (2 revisions) (flutter/engine#42204) 2023-05-22 [email protected] Roll Skia from 2d4ea9542e83 to 76303a5498e9 (1 revision) (flutter/engine#42203) 2023-05-22 [email protected] Roll Fuchsia Linux SDK from 88pzkUAkSKsJrNG38... to NE_eTA29vOHN4goJL... (flutter/engine#42202) 2023-05-21 [email protected] [macOS] Clean up unused methods in FlutterRenderer (flutter/engine#42196) 2023-05-21 [email protected] Roll Fuchsia Mac SDK from JU-dKW3CQIUzhbqWE... to HPZKiLZlLCR6moOCE... (flutter/engine#42201) 2023-05-21 [email protected] Roll Skia from 5b2005e47bf3 to 2d4ea9542e83 (1 revision) (flutter/engine#42200) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 88pzkUAkSKsJ to LrfeC0dLk8To fuchsia/sdk/core/mac-amd64 from JU-dKW3CQIUz to QAwORJOkyNl4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…27325) flutter/engine@f0f3fe7...e04c147 2023-05-22 [email protected] Roll Fuchsia Linux SDK from NE_eTA29vOHN4goJL... to LrfeC0dLk8ToJVik5... (flutter/engine#42208) 2023-05-22 [email protected] Roll Fuchsia Mac SDK from HPZKiLZlLCR6moOCE... to QAwORJOkyNl4J3x4Y... (flutter/engine#42207) 2023-05-22 [email protected] Roll Skia from 16c60e5bebfc to ef226c5a7930 (1 revision) (flutter/engine#42206) 2023-05-22 [email protected] Roll Skia from 79088c6b7a33 to 16c60e5bebfc (1 revision) (flutter/engine#42205) 2023-05-22 [email protected] Roll Skia from 76303a5498e9 to 79088c6b7a33 (2 revisions) (flutter/engine#42204) 2023-05-22 [email protected] Roll Skia from 2d4ea9542e83 to 76303a5498e9 (1 revision) (flutter/engine#42203) 2023-05-22 [email protected] Roll Fuchsia Linux SDK from 88pzkUAkSKsJrNG38... to NE_eTA29vOHN4goJL... (flutter/engine#42202) 2023-05-21 [email protected] [macOS] Clean up unused methods in FlutterRenderer (flutter/engine#42196) 2023-05-21 [email protected] Roll Fuchsia Mac SDK from JU-dKW3CQIUzhbqWE... to HPZKiLZlLCR6moOCE... (flutter/engine#42201) 2023-05-21 [email protected] Roll Skia from 5b2005e47bf3 to 2d4ea9542e83 (1 revision) (flutter/engine#42200) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 88pzkUAkSKsJ to LrfeC0dLk8To fuchsia/sdk/core/mac-amd64 from JU-dKW3CQIUz to QAwORJOkyNl4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the methods in
FlutterRendererthat will never be used.These methods allows the engine to get a drawable and present a drawable, but they will never be called on the macOS embedder. This is because they go through the
FlutterMetalRendererConfigstruct toGPUSurfaceMetalSkia, which is bypassed if the engine has a non-null external view embedder, which the macOS always provides.Removing these methods not only cleans up the code (and the confusion), but also reduces the methods that might need to be migrated for the multi-view project.
After this change,
FlutterRendereris left with very few functionalities:deviceandcommandQueue.FlutterRendererConfig.FlutterTextureRegistryandFlutterTextureRegistrarDelegate, linkingFlutterTextureandFlutterTextureRegistrar.We might want to refactor this class, but that's for the future.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.