This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Start of Dart GPU prototype#42228
Merged
auto-submit[bot] merged 6 commits intoflutter:mainfrom May 24, 2023
Merged
Conversation
chinmaygarde
approved these changes
May 24, 2023
|
|
||
| #pragma clang diagnostic push | ||
| #pragma clang diagnostic ignored "-Wdeprecated-declarations" | ||
| current_task_runner_ = fml::MessageLoop::GetCurrent().GetTaskRunner(); |
Contributor
There was a problem hiding this comment.
fml::MessageLoop::GetCurrent is an API only meant to be used on the embedder and we can't know if the call is made on the embedder unless you clarify. You can just define FML_USED_ON_EMBEDDER at the very top of the file and the deprecated declaration warning will go away :)
Contributor
Author
There was a problem hiding this comment.
Ah, makes sense. Done.
| } // namespace testing | ||
| } // namespace impeller | ||
|
|
||
| int main(int argc, char** argv) { |
Contributor
There was a problem hiding this comment.
Instead of installing your own main, use run_all_unittests.cc from //flutter/testing:testing. It does all the usual setup you want :)
Contributor
Author
There was a problem hiding this comment.
Oh whoops, looks like I pulled in testing_lib instead of testing for some reason. Done.
| static std::string InitializeDefault(Dart_Handle wrapper); | ||
|
|
||
| private: | ||
| std::shared_ptr<impeller::Context> context_; |
Contributor
There was a problem hiding this comment.
Disallow copy and assign?
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 24, 2023
CaseyHillers
added a commit
that referenced
this pull request
May 24, 2023
This reverts commit cbfcb77.
bdero
added a commit
to bdero/flutter-engine
that referenced
this pull request
Mar 12, 2024
We moved to lib/gpu some time ago! (Initially added with flutter#42228)
zijiehe-google-com
pushed a commit
to zijiehe-google-com/engine
that referenced
this pull request
Mar 12, 2024
We moved to lib/gpu some time ago! (Initially added with flutter#42228)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been slowly hacking on a prototype alongside a doc (public go link imminent) for a while (the doc has been changing a lot as a result of prototyping) and I think it's time to start landing parts of this prototype/experiment in-tree.
This initial PR just sets up the main context singleton on the UI thread. After this, I'll land the shader management stuff.
I re-used the existing experimental 3D flag for this, since this is meant to replace what can be done with Impeller Scene anyway.