This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Turned back on debug unit tests#42261
Merged
auto-submit[bot] merged 3 commits intoflutter:mainfrom May 23, 2023
Merged
Conversation
gaaclarke
changed the title
gaaclarke
force-pushed
the
turn-back-on-engine-tests-flow-failure
branch
from
9fff75d to
7c597bf
Compare
gaaclarke
force-pushed
the
turn-back-on-engine-tests-flow-failure
branch
from
7c597bf to
2748b4a
Compare
zanderso
approved these changes
May 23, 2023
gaaclarke
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 24, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 24, 2023
flutter/engine@76afb43...aba9dc4 2023-05-23 [email protected] Turned back on debug unit tests (flutter/engine#42261) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
) flutter/engine@76afb43...aba9dc4 2023-05-23 [email protected] Turned back on debug unit tests (flutter/engine#42261) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I refactored the
EXPECT_EXITtests since they are unsafe to execute in a process with multiple threads.This leaves
flutter_desktop_darwin_unittestsdisabled since it has existing issues.fixes flutter/flutter#103757
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.