This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Skwasm] Implement miscellaneous drawing APIs#42324
Merged
auto-submit[bot] merged 7 commits intoflutter:mainfrom May 25, 2023
Merged
[Skwasm] Implement miscellaneous drawing APIs#42324auto-submit[bot] merged 7 commits intoflutter:mainfrom
auto-submit[bot] merged 7 commits intoflutter:mainfrom
Conversation
flutter-dashboard
bot
added
the
platform-web
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
eyebrowsoffire
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 25, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 25, 2023
flutter/engine@6a4e675...ff04d2f 2023-05-25 [email protected] Move checkerboard unit tests onto DisplayList mechanism (flutter/engine#41951) 2023-05-25 [email protected] [Skwasm] Implement miscellaneous drawing APIs (flutter/engine#42324) 2023-05-25 [email protected] Roll Fuchsia Mac SDK from X4uS4T6_J-VUh9M4A... to AgIKKqtBtb6RJnyI9... (flutter/engine#42326) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from X4uS4T6_J-VU to AgIKKqtBtb6R If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
drawVertices,drawPoints, anddrawAtlas.These are the last rendering APIs that are unimplemented in Skwasm! (Although we still need to add platform view support).