This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[deps] Add dart-lang/native packages#42412
Merged
auto-submit[bot] merged 2 commits intomainfrom May 30, 2023
Merged
Conversation
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine, pr: 42412, due to This PR has not met approval requirements for merging. You are a member of flutter-hackers and need 1 more review(s) in order to merge this PR.
|
whesse
approved these changes
May 30, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 30, 2023
flutter/engine@351a7ca...9fa896a 2023-05-30 [email protected] [deps] Add dart-lang/native packages (flutter/engine#42412) 2023-05-30 [email protected] Roll Fuchsia Mac SDK from s0EKNBEvQSUVJhV0J... to BPfBea46iVvtlNBnP... (flutter/engine#42410) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from s0EKNBEvQSUV to BPfBea46iVvt If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://dart-review.googlesource.com/c/sdk/+/267340 starts using the packages on https://github.com/dart-lang/native inside
dart. These packages were added to the Dart DEPS in https://dart-review.googlesource.com/c/sdk/+/295280.This PR adds the dart-lang/native repo to the DEPS of flutter/engine such that the dart build succeeds again.
Pre-launch Checklist
///).