This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix bugprone-unchecked-optional-access errors in image_generator_apng#42450
Merged
zanderso merged 1 commit intoflutter:mainfrom May 31, 2023
Merged
Fix bugprone-unchecked-optional-access errors in image_generator_apng#42450zanderso merged 1 commit intoflutter:mainfrom
zanderso merged 1 commit intoflutter:mainfrom
Conversation
8 tasks
zanderso
approved these changes
May 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 31, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 31, 2023
flutter/engine@ee53c04...8e67cc3 2023-05-31 [email protected] Roll Skia from f475d4f5e080 to cb883f64681b (6 revisions) (flutter/engine#42452) 2023-05-31 [email protected] Fix bugprone-unchecked-optional-access errors in image_generator_apng (flutter/engine#42450) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
andrewkolos
pushed a commit
to andrewkolos/flutter
that referenced
this pull request
May 31, 2023
…7975) flutter/engine@ee53c04...8e67cc3 2023-05-31 [email protected] Roll Skia from f475d4f5e080 to cb883f64681b (6 revisions) (flutter/engine#42452) 2023-05-31 [email protected] Fix bugprone-unchecked-optional-access errors in image_generator_apng (flutter/engine#42450) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #127701
When landing a seemingly unrelated CL, clang-tidy started failing with:
This addresses those checks by making sure frame_info has a value.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.