[Impeller] disable buffer to texture blit for Vulkan.#42686
[Impeller] disable buffer to texture blit for Vulkan.#42686auto-submit[bot] merged 1 commit intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| // |Capabilities| | ||
| bool CapabilitiesVK::SupportsBufferToTextureBlits() const { | ||
| return true; | ||
| return false; |
There was a problem hiding this comment.
Consider an ifdef with !FML_OS_ANDROID and a comment explaining this is implemented and working on non-Android platforms.
There was a problem hiding this comment.
I'm not confident in that given that I can run the gallery on vulkan outside of android
jonahwilliams
added
the
autosubmit
flutter/engine@93afba9...bc6e047 2023-06-09 [email protected] [Impeller] disable buffer to texture blit for Vulkan. (flutter/engine#42686) 2023-06-09 [email protected] Roll ANGLE from 980896406d12 to a185cb8c8924 (1 revision) (flutter/engine#42697) 2023-06-09 [email protected] Roll ANGLE from e9493542672c to 980896406d12 (1 revision) (flutter/engine#42696) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
This fixes some f'd up ness in the images. Will need to debug this separately on Android. For now, we can just turn it off in the caps.