[Impeller] Fix DrawPicture.#43446
Conversation
impeller/aiks/canvas.cc
Outdated
| return true; | ||
| }); | ||
| return; | ||
| pass->AddSubpassInline(std::move(pass)); |
There was a problem hiding this comment.
| pass->AddSubpassInline(std::move(pass)); | |
| GetCurrentPass()->AddSubpassInline(std::move(pass)); |
impeller/aiks/canvas.cc
Outdated
| auto save_count = GetSaveCount(); | ||
| Save(); |
There was a problem hiding this comment.
Move this below the early return below.
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
Uncaught yb linter issue
impeller/entity/entity_pass.cc
Outdated
| return true; | ||
| } | ||
|
|
||
| void EntityPass::IterateAllElements( |
There was a problem hiding this comment.
Consider moving to separate patch, unused
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Is this part of the fixes for flutter/flutter#130078? |
flutter/engine@48bf7ac...491f317 2023-07-06 [email protected] Account for updated Impeller label. (flutter/engine#43450) 2023-07-06 [email protected] [Impeller] Fix DrawPicture. (flutter/engine#43446) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
No this is me nerd-sniping @bdero into fixing this the right way haha |
|
I filed flutter/flutter#130142 to track the work I'm referring to. |
Prior to this patch, `DrawPicture` was untested and a no-op. We needed a new routine to absorb Elements of a cloned pass into another pass, since appending a `Picture` as a subpass would be incorrect behavior for drawing a picture (since subpasses start with a blank image, which gets drawn to and then composited with the parent pass via a separate blending operation).
4 participants
Prior to this patch,
DrawPicturewas untested and a no-op.We needed a new routine to absorb Elements of a cloned pass into another pass, since appending a
Pictureas a subpass would be incorrect behavior for drawing a picture (since subpasses start with a blank image, which gets drawn to and then composited with the parent pass via a separate blending operation).