This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Prevent Skia from trying to use stencil buffers#4362
Merged
brianosman merged 1 commit intoflutter:masterfrom Nov 15, 2017
brianosman:profile-graph
Merged
Prevent Skia from trying to use stencil buffers#4362brianosman merged 1 commit intoflutter:masterfrom brianosman:profile-graph
brianosman merged 1 commit intoflutter:masterfrom
brianosman:profile-graph
Conversation
Contributor
|
Is this for fixing the performance overlay or something more generic? Is there a bug this should link to? |
Contributor
Author
|
Oops. Forgot to link the issue. |
jason-simmons
approved these changes
Nov 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#13018
When linear blending was disabled, we started rendering directly to FBO0 again. We can't attach stencil there, and the profile graph code triggers a path that (by default) uses it. This option forces us to use alternate rendering methods.
Note that the graph rendering code is constructing a fairly complex path. It would probably be much faster to render as a simpler series of drawRect calls for each box (which would get batched inside Skia).