This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Implementing TextScaler for nonlinear text scaling"#44882
Merged
jonahwilliams merged 1 commit intomainfrom Aug 20, 2023
Merged
Revert "Implementing TextScaler for nonlinear text scaling"#44882jonahwilliams merged 1 commit intomainfrom
jonahwilliams merged 1 commit intomainfrom
Conversation
This reverts commit 5741f69.
github-actions
bot
added
platform-android
platform-web
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 20, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 20, 2023
flutter/engine@f4bffdc...2dcfb6c 2023-08-20 [email protected] Roll Skia from e9cf3f1740eb to 4f6b9d08b6d1 (2 revisions) (flutter/engine#44868) 2023-08-20 [email protected] Revert "Implementing TextScaler for nonlinear text scaling" (flutter/engine#44882) 2023-08-18 [email protected] [Embedder API] Add semantic string attributes (flutter/engine#44616) 2023-08-18 [email protected] Implementing TextScaler for nonlinear text scaling (flutter/engine#42062) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…44882) Reverts flutter#42062 Failing due to: >>>>>>>> 08-18 15:59:41.350 3439 3484 E flutter : [ERROR:flutter/shell/platform/android/platform_view_android_jni_impl.cc(902)] Could not locate FlutterJNI#getScaledFontSize method >>>>>>>> 08-18 15:59:41.350 3439 3484 F flutter : [FATAL:flutter/shell/platform/android/library_loader.cc(26)] Check failed: result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #42062
Failing due to: