Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Remove unused HasThreadingRestrictions capability.#45242

Merged
bdero merged 1 commit intoflutter:mainfrom
bdero:bdero/remove-unused-capability
Aug 29, 2023
Merged

[Impeller] Remove unused HasThreadingRestrictions capability.#45242
bdero merged 1 commit intoflutter:mainfrom
bdero:bdero/remove-unused-capability

Conversation

@bdero
Copy link
Contributor

@bdero bdero commented Aug 29, 2023

Noticed this while working through documenting all of the capabilities. I guess we don't need this one anymore?

@bdero bdero requested a review from chinmaygarde August 29, 2023 20:50
@bdero bdero self-assigned this Aug 29, 2023
@bdero bdero added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 29, 2023
@chinmaygarde
Copy link
Contributor

I thought it was needed during image decoding?

@bdero bdero merged commit db3ecf8 into flutter:main Aug 29, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 29, 2023
flutter/engine@1feb930...db3ecf8

2023-08-29 [email protected] [Impeller] Remove unused HasThreadingRestrictions capability. (flutter/engine#45242)
2023-08-29 [email protected] Roll Skia from fb09020ce62d to 8a2754a1ae60 (6 revisions) (flutter/engine#45241)
2023-08-29 [email protected] [Impeller] Update xcode_frame_capture.md (flutter/engine#45230)
2023-08-29 [email protected] Update documentation for updater callback. (flutter/engine#45239)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke pushed a commit to gaaclarke/engine that referenced this pull request Aug 30, 2023
…r#45242)

Noticed this while working through documenting all of the capabilities.
I guess we don't need this one anymore?
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants