This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Deprecate support for big integers in standard message codec#4528
Merged
mravn-google merged 3 commits intoflutter:masterfrom Jan 9, 2018
Merged
Deprecate support for big integers in standard message codec#4528mravn-google merged 3 commits intoflutter:masterfrom
mravn-google merged 3 commits intoflutter:masterfrom
Conversation
Member
|
clang-format is warning about indentation in FlutterCodecs.h. Otherwise LGTM |
Contributor
Author
|
Partly fixes flutter/flutter#12976 |
Contributor
Author
|
@jason-simmons Can you approve this, or do you want Chinmay to chip in? |
jason-simmons
approved these changes
Jan 9, 2018
This was referenced Jan 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The support was originally added only because Dart 1.0 had unlimited size
ints. With Dart 2.0, this no longer makes much sense.