This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Conversation
Contributor
Author
|
Do I need to update |
Contributor
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
Sorry, as I've never seen these files before, I don't think I'm the best person to review. If you can wait a week, this should get picked up in Engine PR triage. Otherwise I would ask in the discord server #hackers-engine who the best reviewer would be.
jason-simmons
approved these changes
Sep 11, 2023
derekxu16
force-pushed
the
trace-to-file
branch
from
c3294ea to
cc68124
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 12, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 12, 2023
flutter/engine@8a8ddae...d4698c6 2023-09-12 [email protected] Roll Skia from 7e9b94634911 to f3f0cab7efd0 (1 revision) (flutter/engine#45710) 2023-09-12 [email protected] Add trace-to-file switch (flutter/engine#45553) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.