This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Oops, allow files in opted-in third_party directories.#46897
Merged
matanlurey merged 3 commits intoflutter:mainfrom Oct 13, 2023
Merged
Oops, allow files in opted-in third_party directories.#46897matanlurey merged 3 commits intoflutter:mainfrom
matanlurey merged 3 commits intoflutter:mainfrom
Conversation
matanlurey
added
the
autosubmit
Contributor
|
I tired this, didn't work, @jason-simmons found out that the below works. Unsure why |
Contributor
Author
|
Ah, |
cyanglaz
approved these changes
Oct 13, 2023
Contributor
cyanglaz
left a comment
cyanglaz
left a comment
There was a problem hiding this comment.
LGTM
Verified locally it works
third_party/.gitignore
Outdated
| !txt/ | ||
| !web_locale_keymap/ | ||
| !web_test_fonts/ | ||
| !web_test_font/ |
Member
There was a problem hiding this comment.
Looks like the removal of the s is a typo?
Contributor
Author
There was a problem hiding this comment.
Yup! Nice catch, thanks.
jason-simmons
approved these changes
Oct 13, 2023
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/46897, due to - The status or check suite Linux linux_web_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 13, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 13, 2023
…6564) Manual roll requested by [email protected] Cannot build log URL because revision "a4e62581525c" is invalid: Luci builds of "Mac mac_ios_engine" for a4e6258 was STARTED 2023-10-13 [email protected] Manual roll Dart SDK from c8143a7c026f to 5844b34768ce (1 revision) (flutter/engine#46909) 2023-10-13 [email protected] Roll Skia from c9601553b0f3 to 4bc4b4d22866 (1 revision) (flutter/engine#46908) 2023-10-13 [email protected] Roll Skia from 8dc8e21a4dec to c9601553b0f3 (3 revisions) (flutter/engine#46907) 2023-10-13 [email protected] Roll Fuchsia Mac SDK from SDPa6SfaKvRRSUCij... to 4DwpR2CMJECZJ8EKz... (flutter/engine#46903) 2023-10-13 [email protected] Roll Skia from b50d7f9aa743 to 8dc8e21a4dec (4 revisions) (flutter/engine#46902) 2023-10-13 [email protected] [Impeller] fix clear color optimization for large subpasses. (flutter/engine#46887) 2023-10-13 [email protected] Oops, allow files in opted-in third_party directories. (flutter/engine#46897) 2023-10-13 [email protected] Roll Skia from e10e6765480a to b50d7f9aa743 (1 revision) (flutter/engine#46899) 2023-10-13 [email protected] Roll Fuchsia Linux SDK from pI1BVH08V0eG0M7sw... to wBb32R567S1alWbfn... (flutter/engine#46898) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from pI1BVH08V0eG to wBb32R567S1a fuchsia/sdk/core/mac-amd64 from SDPa6SfaKvRR to 4DwpR2CMJECZ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes flutter/flutter#136551.